[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Since we've settled on not considering that to be overflow, yeah, I think the patch is fine.  Might be worth being explicit about that at the point you do the shift: that it's known that this discards precision that could leave the true mathematical value outside of the expressible range, and that we are interpreting the spec as allowing us to round to avoid this formal overflow in order to avoid unnecessary UB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73186/new/

https://reviews.llvm.org/D73186