[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 28 05:00:00 PST 2020


gribozavr2 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:109
+  /// \p LangOpts.
+  virtual bool isLanguageVersionSupported(const LangOptions &LangOpts) const {
+    return true;
----------------
Not a critical thing, but I feel like it would be better to put `isLanguageVersionSupported` before `register` functions. That logical order makes more sense to a reader that is not familiar with the class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75289/new/

https://reviews.llvm.org/D75289





More information about the cfe-commits mailing list