[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

[Nathan James via Phabricator via cfe-commits]

njames93 added a comment.

The test cases need fixing as they are causing the build to fail. Also would it be wise to add a .clang-tidy file to libc/ to enable this module for that subdirectory?



================
Comment at: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt:17
+  
\ No newline at end of file

----------------
Not sure why this error is here but can it be resolved


================
Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:17
+
+class RestrictedIncludesPPCallbacks : public PPCallbacks {
+public:
----------------
Should put this in an anonymous namespace as it doesn't need external linkage


================
Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.h:18
+
+/// FIXME: Write a short description.
+///
----------------
FIXME


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/llvmlibc-restrict-system-libc-headers.rst:6
+
+Finds includes of system libc headers within llvm-libc implementations.
+
----------------
Should explain the rationale for this check


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75332/new/

https://reviews.llvm.org/D75332