[PATCH] D75271: [Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added a comment.

In D75271#1896724 <https://reviews.llvm.org/D75271#1896724>, @Szelethus wrote:

> Let's change this to either `CheckerManger` or `AnalysisManager`.


Did you read my comments? I tried `CheckerManager` first, but it does not work, because `CheckerRegistry` does not have it. If I pass it to `CheckerRegistry`, then the `printXXX()` functions will not compile, because they do not have it.

In D75271#1896182 <https://reviews.llvm.org/D75271#1896182>, @Szelethus wrote:

> Well, I like to say that "Any manager can be retrieved in clang at arbitrary places if you try hard enough", so I think either that //actually// satisfies this would be fine :)


This is not always true, especially if the manager does not exist at that particular place. There is not `CheckerManager` in the `printXXX()` functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75271/new/

https://reviews.llvm.org/D75271