[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 27 13:47:14 PST 2020


ABataev added a comment.

Also, would be good to add more tests for the situations that should not be handled, like just `(a+b)`, explicit casts, etc.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9966
+def err_omp_non_lvalue_in_map_or_motion_clauses: Error<
+  "expected addressable lvalue in '#pragma omp target update' and '#pragma omp target map'"
+  >;
----------------
I still would change this message to something like `expected addressable lvalue in '%0' clause`, where `%0` must be one of `map|to|from` to be more specific and correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75077/new/

https://reviews.llvm.org/D75077





More information about the cfe-commits mailing list