[PATCH] D67537: [clangd] Client-side support for inactive regions

[Nathan Ridge via Phabricator via cfe-commits]

nridge marked an inline comment as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:193
+      if (scopes[0] == "meta.disabled") {
+        this.inactiveDecorationIndex = index;
+        return vscode.window.createTextEditorDecorationType({
----------------
hokein wrote:
> hmm, looks like clangd [omits](https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/SemanticHighlighting.cpp#L454) the `InactiveCode` token.
> 
> I'd suggest we send it like other tokens, that will simplify the patch, we don't need the `inactiveDecorationIndex` and `isInactive`, I think it also helps when we migrate to the official implementation. WDYT?
> 
> 
This was discussed fairly extensively in the server-side review (https://reviews.llvm.org/D67536).

In the end, we decided to go with this approach of having a separate field in the protocol for inactive lines, for a variety of reasons including the one discussed in https://reviews.llvm.org/D67536#inline-616346


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67537/new/

https://reviews.llvm.org/D67537