[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:76
+
+  const auto SE = utils::getFileExtension(FileName, Check.SuspiciousExtensions);
+  if (!SE)
----------------
Please don't use `auto` here (the type isn't spelled out in the initialization).


================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:36
+bool parseFileExtensions(StringRef AllFileExtensions,
+                         FileExtensionsSet &FileExtensions, char delimiter) {
+  SmallVector<StringRef, 5> Suffixes;
----------------
`Delimiter` here as well.


================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:54
+getFileExtension(StringRef FileName, const FileExtensionsSet &FileExtensions) {
+  StringRef extension = llvm::sys::path::extension(FileName);
+  if (extension.empty())
----------------
`Extension`


================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:9
+
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_UTILS_HEADER_FILE_EXTENSIONS_UTILS_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_UTILS_HEADER_FILE_EXTENSIONS_UTILS_H
----------------
Can drop the `HEADER` from these macros.


================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:48
+bool parseFileExtensions(StringRef AllFileExtensions,
+                         FileExtensionsSet &FileExtensions, char delimiter);
+
----------------
delimiter -> Delimiter per our usual naming conventions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74669/new/

https://reviews.llvm.org/D74669