[PATCH] D75057: Syndicate, test and fix base64 implementation

serge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 27 11:35:20 PST 2020


serge-sans-paille marked 3 inline comments as done.
serge-sans-paille added inline comments.


================
Comment at: llvm/unittests/Support/Base64Test.cpp:30
+  // from: https://tools.ietf.org/html/rfc4648#section-10
+  TestBase64("", "");
+  TestBase64("f", "Zg==");
----------------
hokein wrote:
> nit: i would just inline the `TestBase64`.
I wouldn't :-) I find it easier to read like that, if that's okay with you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75057/new/

https://reviews.llvm.org/D75057





More information about the cfe-commits mailing list