[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added a comment.

In D75171#1893811 <https://reviews.llvm.org/D75171#1893811>, @Szelethus wrote:

> Im sorry, i though we talked about internal code and we're stuck with the checker interface -- this should definitely be solved by changing the parameter of the `shouldRegister` function to `CheckerManager`. If you want to emit errors for incorrect file, there is an example in `UninitializedObjectChecker` and maybe in `GenericTaintChecker`.


Sorry, but it does not work. It is impossible to use `CheckerManager` as parameter for `shouldRegisterXXX()` because `CheckerRegistry` does not have it. If I add `CheckerManager` to `CheckerRegistry` then the `printXXX()` functions will not work because they do not have `CheckerManager` at all.  I tried to add `AnalyzerOptions` as a second parameter (see D75271 <https://reviews.llvm.org/D75271>), but it does not help in printing error message. I need a way to solve 44998 <https://bugs.llvm.org/show_bug.cgi?id=44998> by rejecting the checker if the option is disabled **and** printing an error message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75171/new/

https://reviews.llvm.org/D75171