[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

Thu Feb 27 09:22:03 PST 2020

hans added a comment.

In D74846#1895319 <https://reviews.llvm.org/D74846#1895319>, @aganea wrote:

> Thanks @hans! Nevertheless I think this is a good change and we should push it for 11.0. I was indeed seeing better timings on our end with what @llunak was proposing, we are heavy users of PCH headers (and migrating to modules is not trivial in our case, lots of code branching & integrations)

Right, I have no objections against this re-landing on master once the problem in PR44953 is understood and fixed.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74846/new/

https://reviews.llvm.org/D74846