[Diffusion] rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication
Adrian Prantl via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 27 08:31:40 PST 2020
aprantl added inline comments.
BRANCHES
master
/clang/test/OpenMP/PR44893.c:3 A test with no CHECK lines also passes if you symlink /bin/true to clang :-)
It also doesn't indicate what is being relevant and when it comes to maintaining / updating the test we won't know what is important to keep.
The fact that there was a crash that wasn't hit by the test suite indicates that there was some behavior that wasn't tested before, so we should really try to check that behavior.
Users:
jdoerfert (Author)
https://reviews.llvm.org/rG396b7253944e
More information about the cfe-commits
mailing list