[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

[John Brawn via Phabricator via cfe-commits]

john.brawn marked 2 inline comments as done.
john.brawn added inline comments.


================
Comment at: clang/docs/ClangPlugins.rst:74
+
+  class ExampleAttrInfo : public ParsedAttrInfo {
+  public:
----------------
aaron.ballman wrote:
> We should be documenting the fields of `ParsedAttrInfo` that the user would be interacting with. We should also consider whether we are introducing a new stability guarantee with that interface and document accordingly. I think we should not promise that this structure will be stable from release to release, but it will be stable within a given release (e.g., the type can change between Clang 11 -> Clang 12, but the type will not change between Clang 11 -> Clang 11.0.1).
I'll add documentation of the relevant fields. As to API stability, looking at Tooling.rst it says only libclang has a stable API (or rather, it says libclang has a stable API, says libtooling doesn't, and says nothing about plugins).


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6702
 
+  if (AL.getInfo().handleDeclAttribute(S, D, AL))
+    return;
+
----------------
aaron.ballman wrote:
> I think this might make more logical sense as part of the `default` label in the `switch` statement.
Sounds reasonable, I'll do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D31342/new/

https://reviews.llvm.org/D31342