[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

Wed Feb 26 14:11:40 PST 2020

njames93 marked an inline comment as done.
njames93 added inline comments.

================
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:518
+    // Linkage Spec can just be ignored
+    // FIXME: Any other DeclContext kinds that can be safely disregarded
+    if (isa<LinkageSpecDecl>(Ctx))
----------------
aaron.ballman wrote:
> I would imagine we'd want to skip an `ExternCContextDecl` for similar reasons, though I am struggling to find a test case that actually generates that context.
I couldn't figure a way to generate one of those either. However if a context type that isnt found matched the assertions should go off and we can look into the issue again

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75202/new/

https://reviews.llvm.org/D75202