[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 26 13:06:44 PST 2020


erichkeane added a comment.

I don't see anything glaring here, but I would love some better explanation as to the goal here.  I don't see this used anywhere, the commit message is a bit underwhelming in its reasoning, and there is no test/etc showing why I would want this.



================
Comment at: clang/include/clang/Sema/ParsedAttr.h:115
 /// 3: __attribute__(( format(printf, 1, 2) )). ParmName/Args/NumArgs all used.
 /// 4: __attribute__(( aligned(16) )). ParmName is unused, Args/Num used.
 ///
----------------
Can you update this comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75210/new/

https://reviews.llvm.org/D75210





More information about the cfe-commits mailing list