[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Did you want to delete the lexer check in getDeducedType or is that another patch?



================
Comment at: clang-tools-extra/clangd/Hover.cpp:533
+  }
+  auto TokensAroundCursor =
+      syntax::spelledTokensTouching(*CurLoc, AST.getTokens());
----------------
again, I'd stick with "touching" to match syntax::tokens


================
Comment at: clang-tools-extra/clangd/Hover.cpp:542
+  // identifier-or-keyword token is equivalent.
+  SourceLocation SLocID;
+  SourceLocation SLocAutoKW;
----------------
nit: we don't tend to use SLoc to refer to SourceLocations outside SourceManager, or ID to refer to identifiers.
IdentLoc, AutoLoc?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75176/new/

https://reviews.llvm.org/D75176