[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)
Christophe Calmejane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 26 07:04:32 PST 2020
christophe-calmejane added a comment.
In D44609#1875172 <https://reviews.llvm.org/D44609#1875172>, @Wawha wrote:
> In D44609#1871612 <https://reviews.llvm.org/D44609#1871612>, @MyDeveloperDay wrote:
>
> > Correct follow that description on how to request commit access
>
>
> It's done. I have the commit right, and push that change on github : https://github.com/llvm/llvm-project/commit/fa0118e6e588fe303b08e7e06ba28ac1f8d50c68
>
> Thank you for the review and advices!
Nice to finally see this patch integrated!
But, it looks like you didn't include all the test case I posted 1.5y ago in this post, that are still problematic and not formatting correctly with your patch:
For example, this simple case do not format correctly:
paramBeforeAndAfterLambda(8,[](int x){call();},5);
The output is:
paramBeforeAndAfterLambda(
8,
[](int x)
{
call();
},
5);
although I would expect to see
paramBeforeAndAfterLambda(8,
[](int x)
{
call();
},
5);
See my proposed fix in the discussion, but note that I don't think it's clean enough to be accepted :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D44609/new/
https://reviews.llvm.org/D44609
More information about the cfe-commits
mailing list