[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 25 17:21:57 PST 2020
MaskRay added a comment.
In D75097#1892545 <https://reviews.llvm.org/D75097#1892545>, @efriedma wrote:
> In terms of tests, we can add cc1as tests to clang/test/Misc; just need to be marked `REQUIRES: arm-registered-target` or something like that.
>
> That said, if we need to write cc1as-specific tests for anything other than the command-line parsing, probably something has gone wrong.
Thanks.
In D75097#1892543 <https://reviews.llvm.org/D75097#1892543>, @efriedma wrote:
> Does UseNamesOnTempLabels really need to be configurable? If we're going to force it to false everywhere, might as well just get rid of it.
It is used by MCAsmStreamer (e.g. llvm-mc -filetype=asm; the output is also assembly).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75097/new/
https://reviews.llvm.org/D75097
More information about the cfe-commits
mailing list