[PATCH] D69876: Support output constraints on "asm goto"

[Bill Wendling via cfe-commits]

Hi Vlad,

I just submitted a fix for this: e11f9fb4508534d31b09d2ba6cd22428ccc75f65

On Tue, Feb 25, 2020 at 11:42 AM Vlad Vereschaka via Phabricator <
reviews at reviews.llvm.org> wrote:

> vvereschaka added a comment.
>
> Hello @void ,
>
> this commit breaks Aarch64 builder with failed
> `Clang::uninit-asm-goto.cpp` test
> http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5020
>
> - FAIL: Clang::uninit-asm-goto.cpp
>
>   ******************** TEST 'Clang :: Analysis/uninit-asm-goto.cpp' FAILED
> ********************
>   Script:
>   --
>   : 'RUN: at line 1';
>  c:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\build\bin\clang.exe -cc1
> -internal-isystem
> c:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\build\lib\clang\11.0.0\include
> -nostdsysteminc -std=c++11 -Wuninitialized -verify
> C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\clang\test\Analysis\uninit-asm-goto.cpp
>   --
>   Exit Code: 1
>
>   Command Output (stdout):
>   --
>   $ ":" "RUN: at line 1"
>   $
> "c:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\build\bin\clang.exe"
> "-cc1" "-internal-isystem"
> "c:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\build\lib\clang\11.0.0\include"
> "-nostdsysteminc" "-std=c++11" "-Wuninitialized" "-verify"
> "C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\clang\test\Analysis\uninit-asm-goto.cpp"
>   # command stderr:
>   error: 'warning' diagnostics seen but not expected:
>
>     File
> C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\clang\test\Analysis\uninit-asm-goto.cpp
> Line 6: value size does not match register size specified by the constraint
> and modifier
>
>     File
> C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\clang\test\Analysis\uninit-asm-goto.cpp
> Line 6: value size does not match register size specified by the constraint
> and modifier
>
>   error: 'note' diagnostics seen but not expected:
>
>     File
> C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\clang\test\Analysis\uninit-asm-goto.cpp
> Line 6: use constraint modifier "w"
>
>     File
> C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\clang\test\Analysis\uninit-asm-goto.cpp
> Line 6: use constraint modifier "w"
>
>   4 errors generated.
>
> would you fix the problem or revert the commit?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D69876/new/
>
> https://reviews.llvm.org/D69876
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200225/7546dac2/attachment.html>