[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 25 03:40:14 PST 2020


NoQ added a comment.

In D75045#1891032 <https://reviews.llvm.org/D75045#1891032>, @balazske wrote:

> An improvement can be made if the check runs only when size of `char` and `int` are equal.


How many such platforms can you name? Please correct me if i'm wrong but it sounds like we're adding a lot of logic to maintain for a very very low-value check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75045/new/

https://reviews.llvm.org/D75045





More information about the cfe-commits mailing list