[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 25 00:32:46 PST 2020


MyDeveloperDay added a comment.

I tend to agree with your assessment, I think its worth waiting for some others to comment.



================
Comment at: clang/unittests/Format/FormatTest.cpp:10293
                    Tab));
-  EXPECT_EQ("/*\n"
-            "\t      a\t\tcomment\n"
----------------
fickert wrote:
> MyDeveloperDay wrote:
> > Sorry this isn't clear to be which test this is a duplicate of, as this is an example where there are tabs in the comment and trailing tabs
> This test case is identical to the one in line 10182-10190. There are several test cases that appear multiple times, but usually with changes to the formatting settings in between. This is not the case for these two test cases (no changes in between), so this one seems to be obsolete.
thank you for highlighting that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75034/new/

https://reviews.llvm.org/D75034





More information about the cfe-commits mailing list