[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added a comment.

In D69662#1889545 <https://reviews.llvm.org/D69662#1889545>, @Szelethus wrote:

> Sorry for the slack :)
>
> One should never count on the invocation order of callback funcions in between checkers. In fact, I'm not too sure that my patches affect this, but I suspect that it does, as the container of choice for checker objects is `std::vector`.


With checker dependencies introduced, i think it's not an unreasonable guarantee to make. Like, if you rely on your dependency to model things for you, you probably want to have your callbacks called after everything is set up by the dependency.

That said, it's not always obvious what does "after" mean. I wouldn't be shocked if it turns out that the correct order is different in pre-stmt and post-stmt (i.e., dependent - dependency - actual event - dependency - dependent).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69662/new/

https://reviews.llvm.org/D69662