[PATCH] D74760: [Analyzer] Fix for iterator modeling and checkers: handle negative numbers correctly

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 24 08:49:55 PST 2020


Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.

This patch is a good testament to how well those debug functions turned out. LGTM.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:203
   auto &SVB = State->getStateManager().getSValBuilder();
+  auto &BVF = State->getStateManager().getBasicVals();
 
----------------
Don't use auto here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74760/new/

https://reviews.llvm.org/D74760





More information about the cfe-commits mailing list