[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script
Csaba Dabis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 24 07:44:55 PST 2020
Charusso added a comment.
Thanks for the reviews! Are we good to go?
================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:112
void enableFixitsAsRemarks() { FixitsAsRemarks = true; }
+ void enableFixItApplication() { ApplyFixIts = true; }
----------------
alexfh wrote:
> nit: I'd suggest naming the method closer to the name of the corresponding field, e.g. `enableApplyFixIts`. Why isn't this `setApplyFixIts(bool)` btw?
We do not support the disable way of options, so let us make it `enableApplyFixIts()`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69746/new/
https://reviews.llvm.org/D69746
More information about the cfe-commits
mailing list