[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

Mon Feb 24 06:31:59 PST 2020

vingeldal added a comment.

In D74463#1889157 <https://reviews.llvm.org/D74463#1889157>, @vingeldal wrote:

> > - how do we either not warn on this by default or how does the user tell us to not warn on it (without requiring them to jump through hoops like changing the types of the arguments)?
>
> -I'v used comments in the source code to tell the tool to ignore cases that I'v identified as false positives. That has worked without any issues for me and I wouldn't say it's a hassle. Is that no longer supported in clang tidy or was I using another tool and just projected that memory on clang-tidy?
>  I'm confident that clang-format atleast has a means of locally suppressing rules.

Found what I was thinking of: "// NOLINT(cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type)"
Do you think this is too much jumping through hoops or would that suffice as a means to get rid of false positives?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74463/new/

https://reviews.llvm.org/D74463