[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

Maximilian Fickert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 24 04:34:54 PST 2020


fickert added a comment.

I understand the caution around changing the unit tests. The tests I modified assumed that alignment would be made with mixed tabs and spaces, which is arguably not the expected behavior with `UT_ForContinuationAndIndentation` (see https://bugs.llvm.org/show_bug.cgi?id=38381).  I removed a test case that was a duplicate (the one in line 10293 is identical to the one in line 10182, and there are no changes to the formatting configuration in between). I added two test cases to ensure that the behavior is consistent for alignment in multi-line comments, e.g. the formatted code should be

  {
  \t/* aaaa
  \t   bbbb
  }

instead of

  {
  \t/* aaaa
  \t\t bbbb
  }

when using `UT_ForContinuationAndIndentation` and a tab width of 2.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75034/new/

https://reviews.llvm.org/D75034





More information about the cfe-commits mailing list