[PATCH] D75017: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

Kan Shengchen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 23 18:04:05 PST 2020


skan marked an inline comment as done.
skan added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2175
+def mbranches_within_32B_boundaries : Flag<["-"], "mbranches-within-32B-boundaries">, Flags<[DriverOption]>, Group<m_Group>,
+  HelpText<"Align branches within 32-byte boundary">;
 def mfancy_math_387 : Flag<["-"], "mfancy-math-387">, Group<clang_ignored_m_Group>;
----------------
annita.zhang wrote:
> HelpText<"Align selected branches (fused/jcc/jmp) within 32-byte boundary. The branch types and boundary size can be overwritten by other specific options">;
This helptext seems too long.  Could we use `HelpText<"Align selected branches (fused, jcc, jmp) within 32-byte boundary">`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75017/new/

https://reviews.llvm.org/D75017





More information about the cfe-commits mailing list