[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Sat Feb 22 10:31:48 PST 2020

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

In D74860#1888024 <https://reviews.llvm.org/D74860#1888024>, @Mordante wrote:

> In D74860#1883415 <https://reviews.llvm.org/D74860#1883415>, @rjmccall wrote:
>
> > Can we test the same thing in C++?
>
>
> I'll add some tests, but C++ uses a different codepath for c-style casts.

Since the warning applies in both modes, we generally need to be testing all the cases in both.  The implementation being significantly different is a *better* reason to do this.

Anyway, thanks, LGTM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74860/new/

https://reviews.llvm.org/D74860