[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 22 10:05:15 PST 2020


Mordante added a comment.

In D74860#1883415 <https://reviews.llvm.org/D74860#1883415>, @rjmccall wrote:

> Can we test the same thing in C++?


I'll add some tests, but C++ uses a different codepath for c-style casts.

In D74860#1883480 <https://reviews.llvm.org/D74860#1883480>, @nickdesaulniers wrote:

> Also, make sure to run `git-clang-format HEAD~` on the patch, as the linter suggests. Thanks for the patch.


I'd rather not run it on the tests. The new code uses the same style as the surrounding code. If wanted I can run the formatter on the changed test files and commit them separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74860/new/

https://reviews.llvm.org/D74860





More information about the cfe-commits mailing list