[PATCH] D74787: [IRBuilder] Always respect inserter/folder

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 22 00:03:35 PST 2020


jdoerfert added a comment.

> There should be at most two iterations, one to perform folds and one to verify the fixpoint. If there are more iterations, that's a bug in worklist management

FWIW, the Attributor uses basically the same scheme. It helps us to monitor iteration increases/decreases of patchs and prevents subtle bugs that would escape the regressions tests but hit the iteration limit in real code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74787/new/

https://reviews.llvm.org/D74787





More information about the cfe-commits mailing list