[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

Please simplify the test case - at least to remove the long/uppercase identifiers to use placeholder names (this avoids any accidental semantic meaning they might carry (or appear to carry, but not actually carry)).

What's the failure mode this is avoiding? There's no checking for the behavior of the compiler here, other than "it does not crash" - that's usually a sign of undertesting. If the program crashed without the fix, then there's some specific behavior that's desirable that was hiding behind the crash, something more specific than "does anything other than crash". Please include testing (I'm guessing some FileChecking on IR output in this case, but haven't looked closely)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74846/new/

https://reviews.llvm.org/D74846