[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 21 07:37:15 PST 2020


sammccall marked an inline comment as done.
sammccall added a comment.

Thanks Richard! Haojian agreed to take a look at this.



================
Comment at: clang/lib/AST/ExprConcepts.cpp:186
+  if (Dependent)
+    addDependence(ExprDependence::ValueInstantiation);
 }
----------------
Per Richard's comment, it sounds like this may be incorrect in obscure cases (if we have a non-dependent requirement that is always unsatisfied, but parameters are instantiation-dependent). I'll add a FIXME


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71920/new/

https://reviews.llvm.org/D71920





More information about the cfe-commits mailing list