[PATCH] D74907: libclang: Make shared object symbol exporting by default

Thu Feb 20 12:19:53 PST 2020

thakis added a comment.

Looks like things are still broken in several ways even with this in:

  [2600/2950] Linking CXX executable bin\c-index-test.exe
   FAILED: bin/c-index-test.exe 
   cmd.exe /C "cd . && C:\b\s\w\ir\cache\builder\src\third_party\llvm-build-tools\cmake-3.12.1-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir --manifests  -- C:\b\s\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\9ff60e43ba91947baca460d0ca3b1b980c3a2c23\VC\Tools\MSVC\14.23.28105\bin\Hostx64\x64\link.exe /nologo tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir\c-index-test.c.obj tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir\core_main.cpp.obj tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir\C_\b\s\w\ir\cache\builder\src\third_party\llvm\llvm\resources\windows_version_resource.rc.res  /out:bin\c-index-test.exe /implib:lib\c-index-test.lib /pdb:bin\c-index-test.pdb /version:0.0  /machine:x64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console  lib\LLVMSupport.lib lib\libclang.lib lib\clangAST.lib lib\clangBasic.lib lib\clangCodeGen.lib lib\clangFrontend.lib lib\clangIndex.lib lib\clangSerialization.lib lib\LLVMCoverage.lib lib\LLVMLTO.lib lib\LLVMObjCARCOpts.lib lib\LLVMPasses.lib lib\LLVMCoroutines.lib lib\LLVMipo.lib lib\LLVMIRReader.lib lib\LLVMAsmParser.lib lib\LLVMLinker.lib lib\LLVMInstrumentation.lib lib\LLVMVectorize.lib lib\LLVMCodeGen.lib lib\LLVMBitWriter.lib lib\LLVMScalarOpts.lib lib\LLVMAggressiveInstCombine.lib lib\LLVMInstCombine.lib lib\LLVMTarget.lib lib\clangFrontend.lib lib\clangDriver.lib version.lib lib\clangParse.lib lib\LLVMOption.lib lib\clangSerialization.lib lib\clangSema.lib lib\clangAnalysis.lib lib\clangASTMatchers.lib lib\clangEdit.lib lib\clangFormat.lib lib\clangToolingInclusions.lib lib\clangToolingCore.lib lib\clangAST.lib lib\LLVMFrontendOpenMP.lib lib\LLVMTransformUtils.lib lib\LLVMAnalysis.lib lib\LLVMObject.lib lib\LLVMBitReader.lib lib\LLVMMCParser.lib lib\LLVMTextAPI.lib lib\LLVMProfileData.lib lib\clangRewrite.lib lib\clangLex.lib lib\clangBasic.lib lib\LLVMCore.lib lib\LLVMRemarks.lib lib\LLVMBitstreamReader.lib lib\LLVMMC.lib lib\LLVMBinaryFormat.lib lib\LLVMDebugInfoCodeView.lib lib\LLVMDebugInfoMSF.lib lib\LLVMSupport.lib C:\b\s\w\ir\cache\builder\src\third_party\llvm-build-tools\zlib-1.2.11\zlib.lib psapi.lib shell32.lib ole32.lib uuid.lib advapi32.lib delayimp.lib -delayload:shell32.dll -delayload:ole32.dll lib\LLVMDemangle.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
   LINK: command "C:\b\s\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\9ff60e43ba91947baca460d0ca3b1b980c3a2c23\VC\Tools\MSVC\14.23.28105\bin\Hostx64\x64\link.exe /nologo tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir\c-index-test.c.obj tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir\core_main.cpp.obj tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir\C_\b\s\w\ir\cache\builder\src\third_party\llvm\llvm\resources\windows_version_resource.rc.res /out:bin\c-index-test.exe /implib:lib\c-index-test.lib /pdb:bin\c-index-test.pdb /version:0.0 /machine:x64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console lib\LLVMSupport.lib lib\libclang.lib lib\clangAST.lib lib\clangBasic.lib lib\clangCodeGen.lib lib\clangFrontend.lib lib\clangIndex.lib lib\clangSerialization.lib lib\LLVMCoverage.lib lib\LLVMLTO.lib lib\LLVMObjCARCOpts.lib lib\LLVMPasses.lib lib\LLVMCoroutines.lib lib\LLVMipo.lib lib\LLVMIRReader.lib lib\LLVMAsmParser.lib lib\LLVMLinker.lib lib\LLVMInstrumentation.lib lib\LLVMVectorize.lib lib\LLVMCodeGen.lib lib\LLVMBitWriter.lib lib\LLVMScalarOpts.lib lib\LLVMAggressiveInstCombine.lib lib\LLVMInstCombine.lib lib\LLVMTarget.lib lib\clangFrontend.lib lib\clangDriver.lib version.lib lib\clangParse.lib lib\LLVMOption.lib lib\clangSerialization.lib lib\clangSema.lib lib\clangAnalysis.lib lib\clangASTMatchers.lib lib\clangEdit.lib lib\clangFormat.lib lib\clangToolingInclusions.lib lib\clangToolingCore.lib lib\clangAST.lib lib\LLVMFrontendOpenMP.lib lib\LLVMTransformUtils.lib lib\LLVMAnalysis.lib lib\LLVMObject.lib lib\LLVMBitReader.lib lib\LLVMMCParser.lib lib\LLVMTextAPI.lib lib\LLVMProfileData.lib lib\clangRewrite.lib lib\clangLex.lib lib\clangBasic.lib lib\LLVMCore.lib lib\LLVMRemarks.lib lib\LLVMBitstreamReader.lib lib\LLVMMC.lib lib\LLVMBinaryFormat.lib lib\LLVMDebugInfoCodeView.lib lib\LLVMDebugInfoMSF.lib lib\LLVMSupport.lib C:\b\s\w\ir\cache\builder\src\third_party\llvm-build-tools\zlib-1.2.11\zlib.lib psapi.lib shell32.lib ole32.lib uuid.lib advapi32.lib delayimp.lib -delayload:shell32.dll -delayload:ole32.dll lib\LLVMDemangle.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin\c-index-test.exe.manifest" failed (exit code 1120) with the following output:
   c-index-test.c.obj : error LNK2019: unresolved external symbol clang_getCString referenced in function index_diagnostic
  (and many other symbols)

and also

  ninja: warning: multiple rules generate lib/libclang.lib. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]

(which is a hard error with newer ninjas).

I'll revert for now to unbreak things. Happy to test new attempts before they go in :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74907/new/

https://reviews.llvm.org/D74907