[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 20 11:52:04 PST 2020


mehdi_amini added a comment.

> It seems to me that we are not dropping the flag of -fdiscard-value-names.

I also reads this as overriding a cc1 flag / ignoring the flag, I don't know if we consistently warn in such cases though.

Overall LGTM for the fix, pending resolution for the warning, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74878/new/

https://reviews.llvm.org/D74878





More information about the cfe-commits mailing list