[PATCH] D74907: libclang: Make shared object symbol exporting by default

Thu Feb 20 10:11:15 PST 2020

cristian.adam added a comment.

> The problem is (I believe) that `add_clang_library(libclang ` is passed `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after your change (due to the change in line 80 in your original change), so libclang.dll isn't built at all any longer. If it was still built, the `_CINDEX_LIB_` logic around line 128 wouldn't be passed for the same reason.

Right, I've uploaded a new patch which should take care of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74907/new/

https://reviews.llvm.org/D74907