[PATCH] D74907: libclang: Make shared object symbol exporting by default

Thu Feb 20 09:43:18 PST 2020

thakis added a comment.

In D74907#1884842 <https://reviews.llvm.org/D74907#1884842>, @cristian.adam wrote:

> In D74907#1884795 <https://reviews.llvm.org/D74907#1884795>, @thakis wrote:
>
> > Thanks! Does this make it so that libclang.dll is built again with -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that correct? If so, could you reinstantiate that too?
>
>
> It should work with `-DLLVM_ENABLE_PIC=NO` because now only the static targets get the `CINDEX_NO_EXPORTS` define.
>
> https://reviews.llvm.org/D74564 only adds `CINDEX_EXPORTS` to `libclang` and not `obj.libclang`.

The problem is (I believe) that `add_clang_library(libclang ` is passed `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after your change (due to the change in line 80 in your original change), so libclang.dll isn't built at all any longer. If it was still built, the `_CINDEX_LIB_` logic around line 128 wouldn't be passed for the same reason.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74907/new/

https://reviews.llvm.org/D74907