[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

Thu Feb 20 06:04:14 PST 2020

hokein added a comment.

In D74709#1882451 <https://reviews.llvm.org/D74709#1882451>, @kbobyrev wrote:

> I think we might still give a warning of some sort that this is known to produce results that are not always correct. Otherwise it might feel like a bug/unknown behavior.

I agree that it would be nice to give a warning. Unfortunately, LSP specification doesn't have such things, returning either a workspaceEdits or an error message, but not both. I think it is still make sense to enable it, I'd say this is a known limitation (this will be mentioned in the user-facing document which I'm working on).

I also test it with `llvm::Optional`, it works (except the same issue of the tablegen files `.inc`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74709/new/

https://reviews.llvm.org/D74709