[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.
Bruno Cardoso Lopes via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 19 15:24:10 PST 2020
bruno added a comment.
Thanks for working on this.
> I'm not sure how (or if it's possible) to add a test that would demonstrate the before/after here. Happy to take advice!
Yea, those are some times hard. Did you try to write a unittest that hits the assertion and trigger this case? Perhaps `clang/unittests/Frontend/PCHPreambleTest.cpp` would be a good example to start off.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74795/new/
https://reviews.llvm.org/D74795
More information about the cfe-commits
mailing list