[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 19 11:55:50 PST 2020


Mordante added a comment.

In D72231#1882658 <https://reviews.llvm.org/D72231#1882658>, @rjmccall wrote:

> Okay.  Can we raise this with the kernel folks instead of just assuming they'll be opposed?  An obvious patch to fix a few dozen places where they're hit by a warning they intentionally enabled really doesn't seem like a burden.  If they push back, fine, we can enable the warning without covering enums.


In the original diff the warning was opt in, in the final version it's enabled by default. So they didn't enable the warning intentionally. I agree; if the kernel folks rather not change their code I can create an option to disable the warning for enums, just like it can already be disabled for `void*`s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72231/new/

https://reviews.llvm.org/D72231





More information about the cfe-commits mailing list