[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 19 07:37:14 PST 2020
rjmccall added inline comments.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:14829
+ if (getLangOpts().CPlusPlus)
+ isInvalid = true;
break;
----------------
Could you hoist this up to the place where we pick the diagnostic and then make it unconditional in the path that always selects an error?
That's a general comment: we should be setting `isInvalid` for all the places below where we select an error diagnostic.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74116/new/
https://reviews.llvm.org/D74116
More information about the cfe-commits
mailing list