[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added a comment.

In D72231#1879347 <https://reviews.llvm.org/D72231#1879347>, @rjmccall wrote:

> In D72231#1878528 <https://reviews.llvm.org/D72231#1878528>, @nathanchance wrote:
>
> > There appear to a be semantic difference between GCC and clang with the current version of this patch which results in a lot of additional warnings in the Linux kernel: https://godbolt.org/z/eHFJd8
>
>
> Warning about casting to an enum seems clearly correct and in scope for this warning.  Warning about casting to `_Bool` seems clearly incorrect and should not be warned about at all.


Maybe we should only warn if the size of the `void*` is smaller than the size of the `enum`? (32b `void*`, 64b `enum`)? https://godbolt.org/z/oAts-u

Otherwise this warning creates a massive mess for us to clean up, and I suspect Linux kernel developers will just end up disabling the warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72231/new/

https://reviews.llvm.org/D72231