[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

Stefanos Baziotis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 18 15:47:31 PST 2020


baziotis marked an inline comment as done.
baziotis added inline comments.


================
Comment at: llvm/tools/opt/PrintSCC.cpp:82-83
       errs() << (*I)->getName() << ", ";
-    if (nextSCC.size() == 1 && SCCI.hasLoop())
-      errs() << " (Has self-loop).";
+    if (nextSCC.size() == 1 && SCCI.hasCycle())
+      errs() << " (Has self-cycle).";
   }
----------------
lebedev.ri wrote:
> baziotis wrote:
> > lebedev.ri wrote:
> > > err, i was specifically talking about this
> > Maybe we can keep the "Has self-loop here".
> Then this would look good to me
Ok, uploading new diff in a bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74801/new/

https://reviews.llvm.org/D74801





More information about the cfe-commits mailing list