[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 18 15:34:27 PST 2020
lebedev.ri added a comment.
While i certainly agree that it's kinda confusing, i'm not really sure this is conceptually correct change.
https://en.wikipedia.org/wiki/Loop_(graph_theory)
> In graph theory, a loop (also called a self-loop or a "buckle") is an edge that connects a vertex to itself. A simple graph contains no loops.
which is exactly the case here.
https://en.wikipedia.org/wiki/Cycle_(graph_theory)
seems more generic than that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74801/new/
https://reviews.llvm.org/D74801
More information about the cfe-commits
mailing list