[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

Tue Feb 18 11:21:04 PST 2020

echristo added a comment.

In D70172#1879481 <https://reviews.llvm.org/D70172#1879481>, @jpienaar wrote:

> This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build with assertions on (clean build at e8e078c <https://reviews.llvm.org/rGe8e078c8bf7987b95298062a644bac9eed26f988> just before this change, broken at this, assert triggering at build fix commit).
>
> https://buildkite.com/mlir/mlir-core/builds/2792#a54fb239-718b-4f0b-a309-f83e46ceb252

Seems reasonable to revert if there's a testcase that they can get from rebuilding llvm with mlir enabled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70172/new/

https://reviews.llvm.org/D70172