[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 18 08:53:21 PST 2020


aaron.ballman closed this revision.
aaron.ballman added a comment.

In D73775#1875921 <https://reviews.llvm.org/D73775#1875921>, @alexeyr wrote:

> @aaron.ballman I just noticed this in https://mlir.llvm.org/getting_started/Contributing/
>
> > Note: if you haven’t used Arcanist to send your patch for review, committers don’t have access to your preferred identity for commit messages. Make sure to communicate it to them through available channels or use the git sign-off functionality to make your identity visible in the commit message.
>
> Can you please make sure the email is listed as `romanov.alexey1 at huawei.com` when committing (I've just set it to primary, so it may be automatic?)


Absolutely -- thank you for clarifying what email address you wanted used. I've commit on your behalf in 5e7d0ebf735a8b70f92acd1f91c7c45423e611cc <https://reviews.llvm.org/rG5e7d0ebf735a8b70f92acd1f91c7c45423e611cc>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73775/new/

https://reviews.llvm.org/D73775





More information about the cfe-commits mailing list