[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

Tue Feb 18 07:02:29 PST 2020

LukeGeeson closed this revision.
LukeGeeson marked an inline comment as not done.
LukeGeeson added inline comments.

================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:784
   EXPECT_TRUE(testAArch64CPU(
+      "cortex-a34", "armv8-a", "crypto-neon-fp-armv8",
+      AArch64::AEK_CRC | AArch64::AEK_SIMD |
----------------
SjoerdMeijer wrote:
> nit: this looks the same as the a35. Would be better to keep the same order of arch extension and also the formatting (to make it easier to eyeball differences).
Good spot thanks, fixed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74483/new/

https://reviews.llvm.org/D74483