[PATCH] D74564: libclang: Add static build support for Windows

Tue Feb 18 00:06:49 PST 2020

yvvan accepted this revision.
yvvan added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang/include/clang-c/Platform.h:31
+#elif defined(CINDEX_EXPORTS)
+  #define CINDEX_LINKAGE __attribute__((visibility("default")))
+#endif
----------------
cristian.adam wrote:
> yvvan wrote:
> > Is it different from just leaving CINDEX_LINKAGE empty?
> On Windows the default symbol visibility is hidden and with CINDEX_LINKAGE we make the symbols visible.
> 
> On Linux it's the other way around, everything is visible, but 
> with CMAKE_CXX_VISIBILITY_PRESET=hidden we will have the Windows behavior and then we need to make CINDEX_LINKAGE point to something that will make the symbols visible.
but this one happens only in non-Windows case (#elif) so it should not change anything I guess

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74564/new/

https://reviews.llvm.org/D74564