[PATCH] D73835: [IRBuilder] Virtualize IRBuilder
Brian Gesiak via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 17 20:17:47 PST 2020
modocache added inline comments.
================
Comment at: llvm/include/llvm/IR/IRBuilder.h:137
+
+ Value *Insert(Value *V, const Twine& = "") const {
+ if (Instruction *I = dyn_cast<Instruction>(V))
----------------
I experienced a tiny regression after applying this patch, and I think this line might be the reason why. I tried addressing the issue in D74754, please give that a review when you get a chance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73835/new/
https://reviews.llvm.org/D73835
More information about the cfe-commits
mailing list