[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.
Michele Scandale via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 17 19:26:12 PST 2020
michele.scandale marked an inline comment as done.
michele.scandale added a comment.
Assuming this is fine, I would need someone landing this change on my behalf since I do not have commit rights. Thanks!
================
Comment at: clang/lib/Parse/ParseTentative.cpp:780
+ if (!SkipUntil(tok::r_square) || Tok.isNot(tok::r_square))
+ return false;
+ ConsumeBracket();
----------------
rjmccall wrote:
> Okay, great. The check for adjacent squares at the end makes sure this doesn't catch an ObjC message send, in case this is ever used in a context where there's attribute/expression ambiguity; that might be worth a comment. Otherwise LGTM.
Comment added. Let me know if the wording is fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74643/new/
https://reviews.llvm.org/D74643
More information about the cfe-commits
mailing list