[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 17 19:06:08 PST 2020


rjmccall accepted this revision.
rjmccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Parse/ParseTentative.cpp:780
+      if (!SkipUntil(tok::r_square) || Tok.isNot(tok::r_square))
+        return false;
+      ConsumeBracket();
----------------
Okay, great.  The check for adjacent squares at the end makes sure this doesn't catch an ObjC message send, in case this is ever used in a context where there's attribute/expression ambiguity; that might be worth a comment.  Otherwise LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74643/new/

https://reviews.llvm.org/D74643





More information about the cfe-commits mailing list