[PATCH] D74704: Support -fuse-ld=lld for riscv

Mon Feb 17 06:52:28 PST 2020

lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.

In D74704#1878944 <https://reviews.llvm.org/D74704#1878944>, @jrtc27 wrote:

> This isn't a new problem. The Linux and FreeBSD toolchains already support -fuse-ld=lld properly, it's just the bare metal one that didn't. People also generally don't include -fuse-ld=lld in CFLAGS, only LDFLAGS, and there's no need to include -mno-relax in LDFLAGS, so I suspect you wouldn't catch many issues. These days (https://reviews.llvm.org/D71820), LLD will give you an informative error (rather than silently mis-linking) if you forget -mno-relax.

Ah, ok, I see how these parts fit together now.

LGTM!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74704/new/

https://reviews.llvm.org/D74704